Where do I submit my patch for TIFF support in libexif

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Where do I submit my patch for TIFF support in libexif

Paulo Neves
Hello comunity.


Airborne Projects has funded for work for the libexif to support TIFF files. We now have a patch for the community but we are unsure where is the best place make it available.

In the libexif project page it was mentioned that the gphoto2 mailing list is the place where libexif stuff has more visibility and I think that Marcus is the owner of the libexif project so here i leave it.

0002-Added-support-for-ARW-tiff-files.patch
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Where do I submit my patch for TIFF support in libexif

Marcus Meissner-4
Hi,

On Wed, Jul 19, 2017 at 10:51:27AM -0700, Paulo Neves via Gphoto-devel wrote:

> Hello comunity.
>
>
> Airborne Projects <https://www.airborneprojects.com>   has funded for work
> for the libexif to support TIFF files. We now have a patch for the community
> but we are unsure where is the best place make it available.
>
> In the libexif project page it was mentioned that the gphoto2 mailing list
> is the place where libexif stuff has more visibility and I think that Marcus
> is the owner of the libexif project so here i leave it.
>
> 0002-Added-support-for-ARW-tiff-files.patch
> <http://gphoto-software.10949.n7.nabble.com/file/n16786/0002-Added-support-for-ARW-tiff-files.patch>  

I have commit rights, and can add it.

Some comments.

What is the reason of this part?
        @@ -131,14 +143,12 @@ exif_data_new_mem (ExifMem *mem)
                }

                /* Default options */
        -#ifndef NO_VERBOSE_TAG_STRINGS
                /*
                 * When the tag list is compiled away, setting this option prevents
                 * any tags from being loaded
                 */
                exif_data_set_option (data, EXIF_DATA_OPTION_IGNORE_UNKNOWN_TAGS);
        -#endif
        -       exif_data_set_option (data, EXIF_DATA_OPTION_FOLLOW_SPECIFICATION);
        +       //exif_data_set_option (data, EXIF_DATA_OPTION_FOLLOW_SPECIFICATION);

                /* Default data type: none */
                exif_data_set_data_type (data, EXIF_DATA_TYPE_COUNT);

Also part 1 seems missing, the patch does not apply cleanly in exif-data.c
as there is no exif_data_new_from_fd

Ciao, Marcus

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Gphoto-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gphoto-devel
Loading...